Author: Kadir Cetinkaya Date: 2020-01-16T11:47:00+01:00 New Revision: b08e8353a89f682861ef947fdb6e229b3de2e37d
URL: https://github.com/llvm/llvm-project/commit/b08e8353a89f682861ef947fdb6e229b3de2e37d DIFF: https://github.com/llvm/llvm-project/commit/b08e8353a89f682861ef947fdb6e229b3de2e37d.diff LOG: [clangd] Dont display `<unknown>` kinds in hover board Summary: Currently when hovering over an `auto` or `decltype` that resolve to a builtin-type, clangd would display `<unknown>` as the kind of the symbol. Drop that to make rendering nicer. Reviewers: usaxena95 Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D72777 Added: Modified: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp index 118d58591d2d..0833a46f088e 100644 --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -522,7 +522,8 @@ markup::Document HoverInfo::present() const { // level 1 and 2 headers in a huge font, see // https://github.com/microsoft/vscode/issues/88417 for details. markup::Paragraph &Header = Output.addHeading(3); - Header.appendText(index::getSymbolKindString(Kind)); + if (Kind != index::SymbolKind::Unknown) + Header.appendText(index::getSymbolKindString(Kind)); assert(!Name.empty() && "hover triggered on a nameless symbol"); Header.appendCode(Name); diff --git a/clang-tools-extra/clangd/unittests/HoverTests.cpp b/clang-tools-extra/clangd/unittests/HoverTests.cpp index 385c064a9dce..65d5e4a6c216 100644 --- a/clang-tools-extra/clangd/unittests/HoverTests.cpp +++ b/clang-tools-extra/clangd/unittests/HoverTests.cpp @@ -1655,7 +1655,7 @@ TEST(Hover, Present) { HI.Kind = index::SymbolKind::Unknown; HI.Name = "X"; }, - R"(<unknown> X)", + R"(X)", }, { [](HoverInfo &HI) { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
