rjmccall added a comment.

Is this approach going to work with scope-local strictness?  We need a way to 
do a comparison that has the non-strict properties but appears in a function 
that enables strictness elsewhere.



================
Comment at: llvm/include/llvm/IR/IRBuilder.h:2342
         return Insert(Folder.CreateFCmp(P, LC, RC), Name);
     return Insert(setFPAttrs(new FCmpInst(P, LHS, RHS), FPMathTag, FMF), Name);
   }
----------------
Can you make a helper method for the common code in the non-constrained paths 
here?

Please document the difference between these two methods.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71467/new/

https://reviews.llvm.org/D71467



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to