[PATCH] D71365: expand printf when compiling HIP to AMDGPU

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

Mostly looks fine, except vectors are supposed to work



================
Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:52
+  } else if (Ty->getTypeID() == Type::DoubleTyID) {
+    return Builder.CreateBitCast(Arg, Int64Ty);
+  } else if (auto PtrTy = dyn_cast<PointerType>(Ty)) {
----------------
No else after return


================
Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:57-58
+
+  llvm_unreachable("unexpected type");
+  return Builder.getInt64(0);
+}
----------------
Dead code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71365/new/

https://reviews.llvm.org/D71365



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits