kateinoigakukun marked an inline comment as done.
kateinoigakukun added inline comments.


================
Comment at: clang/lib/Basic/Targets/WebAssembly.h:122
+    case CC_Swift:
+      return CCCR_OK;
+    default:
----------------
sbc100 wrote:
> This seems to disagree with the longer list in `callingConvSupported`.    Is 
> this going to generate unnecessary warnings?
By default, `checkCallingConvention` allows only `CC_C` due to it's super class 
implementation. This change just allow to use SwiftCC and there is no effect to 
other CC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71823/new/

https://reviews.llvm.org/D71823



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to