aganea added inline comments.
================ Comment at: llvm/lib/Support/Unix/Threading.inc:273 + +int computeHostNumPhysicalThreads() { +#if defined(HAVE_SCHED_GETAFFINITY) && defined(HAVE_CPU_COUNT) ---------------- rnk wrote: > I'm not sure it makes sense to say "physical threads". I think "physical > cores" was meant to distinguish between hardware threads and cores. > Describing hardware execution resources as physical or non-physical isn't > very precise or meaningful in the first place, but I don't think it should > apply to hyper threads. `computeHostNumHardwareThreads()` ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71775/new/ https://reviews.llvm.org/D71775 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits