JonasToth added a comment.

In D72438#1811776 <https://reviews.llvm.org/D72438#1811776>, @thakis wrote:

> I'll point out that with this approach we lose all test coverage of the 
> checker with delayed template parsing on, even though most of the test works 
> in that mode and delayed template parsing is the default when targeting 
> windows.


That is common in clang-tidies tests, because when the templates are not 
parsed, the diagnostics are not emitted. But that is not a problem, because the 
templates only make problems when different instantiation and the template 
itself create different / conflicting diagnostics.
But here that is ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72438/new/

https://reviews.llvm.org/D72438



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to