samparker added a comment.

> It might be possible to rearrange Low Overhead Loops to run before 
> ConstantIslands, but you'd probably need to do more to make it work properly. 
> I don't think ConstantIslands knows how to handle the branches generated by 
> LowOverheadLoop.

This, and the fact that LowOverheadLoops is dependent upon block sizes and 
placement (I need to add a comment in the header on that pass....). So, 
ConstantIslands would have to guarantee not to change branch targets or change 
the distance between blocks around the low-overhead loop constructs. I think 
updating liveness information would be the easier option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57054/new/

https://reviews.llvm.org/D57054



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to