> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > bendjones added a comment. > > In D70284#1752806 <https://reviews.llvm.org/D70284#1752806>, @bendjones wrote: > >> Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? > > > @dexonsmith @erik.pilkington @ahatanak does this look good to go? >
Can you commit the changes that add `objc_arc_inert` separately and rebase the patch after that? Stripping `no_dead_strip` isn’t a prerequisite for adding `objc_arc_inert`. Also, can you check the alignment and `#` at the end of the `_unnamed_nsstring` global variables to make sure `no_dead_strip` is no longer emitted? > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D70284/new/ > > https://reviews.llvm.org/D70284 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
