nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4925 + T.getArch() != llvm::Triple::x86_64) { + S.Diag(getAttrLoc(AL), diag::err_attribute_unsupported) << AL; + return; ---------------- nickdesaulniers wrote: > Why is the target arch also checked in > `clang/lib/Driver/ToolChains/Clang.cpp` in https://reviews.llvm.org/D72222? Ah, https://reviews.llvm.org/D72221 is checking the `__attribute__` syntax, https://reviews.llvm.org/D72222 is checking the command line `-f` syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits