simon_tatham marked an inline comment as done.
simon_tatham added inline comments.
================
Comment at: clang/include/clang/Basic/arm_mve.td:204
let params = T.Float in {
- defm vminnmq : VectorVectorArithmetic<"min_predicated">;
- defm vmaxnmq : VectorVectorArithmetic<"max_predicated">;
+ defm vminnmq : VectorVectorArithmetic<"min_predicated", (? (u32 0))>;
+ defm vmaxnmq : VectorVectorArithmetic<"max_predicated", (? (u32 0))>;
----------------
dmgreen wrote:
> What do these 0's mean?
The IR intrinsic `int_arm_mve_min_predicated` is used for both integer min/max
and floating-point minnm/maxnm. For the integer case it needs a signed/unsigned
flag parameter; so it has to have that parameter in the floating-point case as
well, even though there's nothing to distinguish.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72270/new/
https://reviews.llvm.org/D72270
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
