aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:1055
+ EXPECT_NE(runCheckOnCode<PointeeRTransform>(Cat(S), nullptr, "input.m"),
+ Cat("Object const*target;"));
+ EXPECT_NE(runCheckOnCode<ValueLTransform>(Cat(S), nullptr, "input.m"),
----------------
JonasToth wrote:
> aaron.ballman wrote:
> > The whitespace looks incorrect here.
> It does, but it is actually how it is expected to look.
> All pointer transformations create a double-blank if there was a blank before
> the star. My thought was, that clang-format should be used anyway, so it
> should do this cleanup. (especially with the -format option for clang-tidy).
> The additional whitespace needs to be inserted to avoid `intconst* target;`
> for `int* target;` variables. Thats why it is always added, if necessary or
> not.
> It does, but it is actually how it is expected to look.
Okay, that's fair -- we usually let clang-format handle that sort of thing
anyway and I cannot think of a case where the transformation would be incorrect.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54395/new/
https://reviews.llvm.org/D54395
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
