serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. serge-sans-paille added inline comments.
================ Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): + return val.lower() in (1, "on", "yes", "true", "y",) + ---------------- thakis wrote: > FYI, this is a now-discouraged pattern. It's better to use > llvm_canonicalize_cmake_booleans in the cmake file instead. See > https://reviews.llvm.org/D56912 for an example. Sure! Thanks for pointing at this, I'll fix that once the builds are back to normal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D61446 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
