JonasToth added a comment. Sorry for not responding to the review. I was very busy with other things and overlooked the mails :(
================ Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:82 ast_matchers::MatchFinder *Finder) { - if (!getLangOpts().CPlusPlus17) + if (!getLangOpts().CPlusPlus17 && !getLangOpts().CPlusPlus2a) return; ---------------- We would need to update that line for each new standard, that won't happen :/ I think the opposite logic should be used here and blacklist known-not working standards (and C). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits