jdoerfert added a comment. In D70973#1793061 <https://reviews.llvm.org/D70973#1793061>, @jdoerfert wrote:
> I haven't forgotten about this! With the other two changes to the declare > variant going to happen now,as well, I figured we should look at this again > from a high-level. > > My plan now is: > > 1. Move all of the declare variant context stuff out of clang into the > libFrontendOpenMP. This has various benefits, including reuse capabilities > and the problem of where to put it (which was discussed briefly in my other > declare variant patches), is gone. > 2. Set it up to accept *constant* strings and non-string alike from the > beginning. I'll also make it completely OMPKinds.def based with all the trait > sets and selectors at least parsed properly. Rules what can be nested > together, what can have a score, etc. are all reusable and mostly generated. > 3. Introduce the declare variant begin/end stuff to get math support before > the 10 fork. > 4. Make all declare variant decisions in SemaOverload. Part 1) and 2) are ready for review (D71830 <https://reviews.llvm.org/D71830>). I took some code from here to handle string literals the same as identifiers and I sprinkled a few '"' into the match clauses to test it. (In contrast to this patch, with D71830 <https://reviews.llvm.org/D71830> we will actually remove the quotes when we pretty print the AST instead of adding them.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
