lenary added a comment.

Selfishly, I would like to see the addition of `rvintrin.h` separated from the 
bit-manipulation-specific headers. I'm looking at landing some additions to 
clang/LLVM that include builtins, and don't want to cause merge issues with 
this PR.

I haven't yet had time to fully absorb the bit manipulation spec to ensure that 
these functions, when emulated, match it.



================
Comment at: clang/lib/Headers/rv32bintrin-builtins.h:48
+// Genric aliases
+// e.g. _rv_* is an alias of _rv64_*
+
----------------
Nit: I don't think this is the case here, based on the calls in the 
implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67661/new/

https://reviews.llvm.org/D67661



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to