ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed.
+1, please add a unit test instead. We prefer to keep the number of lit tests in clangd minimal. They're mostly testing the LSP layer and other things which are hard to unit-test. `-fimplicit-modules` does not seem to be one of these things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71586/new/ https://reviews.llvm.org/D71586 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
