Anastasia added a comment.

I was just wondering with SPIRV coming these days, how long should we be 
supporting and maintaining previous SPIR versions. Might be worth clarifying 
that...


================
Comment at: lib/CodeGen/TargetInfo.cpp:7022
@@ -7021,1 +7021,3 @@
 
+class SPIRTargetCodeGenInfo : public TargetCodeGenInfo {
+public:
----------------
Could we please separate this from XCore code?

Add separate anonymous namespace for it and proper heading comment. See XCore 
above as an example.


http://reviews.llvm.org/D17596



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to