jdoerfert added a comment.

>> In fact, the current solution will disregard the `used` attribute here and 
>> not emit the function, which is bad. The Sema solution will dispatch the 
>> right calls and honor the `used` attribute properly.
> 
> Nope, the function is emitted but as an alias to the function with the 
> correct assembler.

The function is marked as `used` but the current solution dies not emit it. 
That is plain wrong. Even if it was not marked as used but externally visible 
you cannot *not emit it*. The alias solution is simply not working.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71241/new/

https://reviews.llvm.org/D71241



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to