alexfh requested changes to this revision. This revision now requires changes to proceed.
================ Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:76 @@ +75,3 @@ + // Note: In unittest, it is empty. + StringRef BuildDirectory; + ---------------- As discussed offline, I'd like `ClangTidyError` to be independent of `ClangTidyContext`, unless this particular optimization saves significant resources. http://reviews.llvm.org/D17335 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits