jdoerfert added a comment. >> There is no evidence that this is more complicated. By all measures, this is >> less complicated (see also below). It is also actually doing the right thing >> when it comes to code emission. Take https://godbolt.org/z/sJiP3B for >> example. The calls are wrong and the definition of base is missing. > > How did you measure it? I have a completely different opinion. Also, tried to > reproduce the problem locally, could not reproduce. It seems to me, the > output of the test misses several important things. You can check it > yourself. `tgt_target_teams()` call uses `@.offload_maptypes` global var but > it is not defined.
Here is the link with the globals not hidden: https://godbolt.org/z/5etB5S The base function is called both times but should not be called at all. What is your local output and why does it differ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71241/new/ https://reviews.llvm.org/D71241 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
