Bigcheese marked an inline comment as done.
Bigcheese added inline comments.
================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1849
+ } while (FormatTok->is(tok::comment));
+ }
if (!(FormatTok->isOneOf(tok::kw_catch, Keywords.kw___except,
----------------
MyDeveloperDay wrote:
> can you use `FormatTok->getNextNonComment()`?
No, `Next` has not been setup at this point, so it will always return `nullptr`.
================
Comment at: clang/unittests/Format/FormatTestObjC.cpp:200
+ "} @catch (NSException *e) {\n"
+ "}\n");
verifyFormat("DEBUG({\n"
----------------
MyDeveloperDay wrote:
> Nit: Could you not keep the original test? just add a new testcase? I get
> uncomfortable about changing tests no matter how trivial
Is there something special about clang-format that causes this concern? I'm all
for testing separate things separately, but the additions to this test are
testing the same leaf lines of code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71239/new/
https://reviews.llvm.org/D71239
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
