probinson added a comment.
Address the inline comments and LGTM.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:866
+ ? dwarf::DW_AT_dwo_name
+ : dwarf::DW_AT_GNU_dwo_name;
NewCU.addUInt(Die, dwarf::DW_AT_GNU_dwo_id, dwarf::DW_FORM_data8,
----------------
This should be moved down under the 'if' so it's in the same scope as the only
use.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1110
+ ? dwarf::DW_AT_dwo_name
+ : dwarf::DW_AT_GNU_dwo_name;
auto *SkCU = TheCU.getSkeleton();
----------------
This should be moved down under the 'if' so it's in the same scope as the only
uses.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71185/new/
https://reviews.llvm.org/D71185
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
