aganea added inline comments.
================ Comment at: clang/tools/driver/driver.cpp:313 + llvm::cl::ResetAllOptionOccurrences(); + StringRef Tool = argv[1] + 4; void *GetExecutablePathVP = (void *)(intptr_t) GetExecutablePath; ---------------- hans wrote: > This feels a little risky to me. Do we still need to rely on argv[1], now > that we have a nice CC1Command abstraction? Risky in what way? What would you suggest? The contents of `argv` are exactly the same in both cases: when called from the CC1Command, or explicitly from the command-line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
