hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:569 +// possible +llvm::Expected<std::vector<Range>> +adjustRenameRanges(llvm::StringRef DraftCode, llvm::StringRef Identifier, ---------------- sammccall wrote: > why returning Expected rather than Optional here - what do we want to do with > the message? I found these error messages are useful for debugging. But you are right, end users are not interested in them, changed to vlog and Optional here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70594/new/ https://reviews.llvm.org/D70594 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
