hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:269 + } + DeletionRange.setBegin(InitStart); + } ---------------- There is an alternative here, I think. The end loc of `FunctionProtoTypeLoc` should point the location after the `)`, e.g. the `Foo()^ : `, would it be easier to use it as as the `InitStart`? it can be retrieved by `CD->getTypeSourceInfo()->getTypeLoc().getEndLoc()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71188/new/ https://reviews.llvm.org/D71188 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
