[PATCH] D71124: [RISCV] support clang driver to select cpu

[Jim Lin via Phabricator via cfe-commits]

Jim added inline comments.


================
Comment at: clang/lib/Basic/Targets/RISCV.h:46
 
+  bool setCPU(const std::string &Name) override {
+    CPU = Name;
----------------
I think this should test cpu name is valid first. And assign Name to CPU, if it 
is valid.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71124/new/

https://reviews.llvm.org/D71124



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits