martong added a comment.

Thanks for addressing this, I just have some minor comments.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5603
+TEST_P(ASTImporterOptionSpecificTestBase, ImplicitlyDeclareSelf) {
+  Decl *FromTU = getTuDecl("__attribute__((objc_root_class))\n"
+                           "@interface Root\n"
----------------
You could use a raw string literal for the code, that way we could get rid of 
the '\n's and the trailing " characters.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71112/new/

https://reviews.llvm.org/D71112



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to