NoQ accepted this revision.
NoQ edited reviewers, added: NoQ; removed: dergachev.a.
NoQ added a comment.

Thanks!! This definitely doesn't sort out all the problems of this kind, but 
that's a strict improvement.

Do you have commit access? Or i could commit for you.



================
Comment at: clang/test/Analysis/uninit-val-const-likeness.c:21
+  for (int i = 0; i < params->noOfSymbols; i++)
+    sum += fooList[i];
+  return sum;
----------------
I suggest adding `// no-warning` markers on the lines on which warnings were 
previously emitted. It doesn't have any physical meaning, just makes it easier 
to understand what the test is about when you accidentally break it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70836/new/

https://reviews.llvm.org/D70836



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to