MaskRay added inline comments.

================
Comment at: llvm/lib/MC/MCAssembler.cpp:1014
+  unsigned EndAddr = StartAddr + Size;
+  return StartAddr / BoundarySize != ((EndAddr - 1) / BoundarySize);
+}
----------------
Division is slow. Pass in the power of 2 and use right shift instead.

You may change `MCMachineDependentFragment::AlignBoundarySize` (a power of 2) 
to a power.


================
Comment at: llvm/lib/MC/MCAssembler.cpp:1022
+  unsigned EndAddr = StartAddr + Size;
+  return EndAddr % BoundarySize == 0;
+}
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to