yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:153
+  // Pass optimization arg to llc.
+  addOptLevelArgs(Args, LlcArgs, true);
+  LlcArgs.push_back("-mtriple=amdgcn-amd-amdhsa");
----------------
Please add /*IsLlc=*/ before true


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70987/new/

https://reviews.llvm.org/D70987



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to