xur marked 4 inline comments as done.
================
Comment at: lib/CodeGen/CodeGenModule.cpp:151
@@ -151,1 +150,3 @@
+ if (CodeGenOpts.hasProfileClangUse() &&
+ !CodeGenOpts.InstrProfileInput.empty()) {
auto ReaderOrErr =
----------------
davidxl wrote:
> Is the second condition still needed? Should it be asserted ?
The second condition is not needed. I'll change the code in the coming patch.
================
Comment at: test/CodeGen/pgo-instrumentation.c:4
@@ +3,3 @@
+// Ensure Pass PGOInstrumentationGenPass is invoked.
+// RUN: %clang-cc1 -O2 -fprofile-instrument=llvm %s -mllvm
-debug-pass=Structure -emit-llvm -o - 2>&1 | FileCheck %s
-check-prefix=CHECK-PGOGENPASS-INVOKED-INSTR-GEN
+// CHECK-PGOGENPASS-INVOKED-INSTR-GEN: PGOInstrumentationGenPass
----------------
davidxl wrote:
> should be %clang_cc1
I think both %clang_cc1 and %clang-cc1 are accepted. But all the other tests
are using %clang_cc1. I'll change.
http://reviews.llvm.org/D15829
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
