jkorous added a comment.
Hi @arthurp, I can review the libclang part of the patch.
Could you please remove the changes that are just code formatting? You can land
those as a separate NFC commit.
================
Comment at: clang/tools/libclang/CIndex.cpp:259
+
+ std::pair<FileID, unsigned> Begin = SM.getDecomposedLoc(
+ SM.getFileLoc(RegionOfInterest.getBegin())),
----------------
This seems like just a clang-format change. Maybe we could separate these as a
NFC commit?
================
Comment at: clang/tools/libclang/CIndex.cpp:436
- bool OnlyLocalDecls
- = !AU->isMainFileAST() && AU->getOnlyLocalDecls();
-
+ bool OnlyLocalDecls = !AU->isMainFileAST() && AU->getOnlyLocalDecls();
+
----------------
This seems like just a clang-format change. Maybe we could separate these as a
NFC commit?
================
Comment at: clang/tools/libclang/CIndex.cpp:1369
-bool
-CursorVisitor::VisitNestedNameSpecifierLoc(NestedNameSpecifierLoc Qualifier) {
+bool CursorVisitor::VisitNestedNameSpecifierLoc(
+ NestedNameSpecifierLoc Qualifier) {
----------------
This seems like just a clang-format change. Maybe we could separate these as a
NFC commit?
Could you please leave out all such changes from this patch? It would be easier
to review. (It seems to me a bunch of changes below are of this nature.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D10833/new/
https://reviews.llvm.org/D10833
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
