vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land.
Lgtm with a small cleanup. ================ Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:674 + if (isRuntimeCounterRelocationEnabled()) { + Type *Int64Ty = Type::getInt64Ty(M->getContext()); + Type *Int64PtrTy = Type::getInt64PtrTy(M->getContext()); ---------------- Could you lazily insert the bias load inside of `lowerIncrement`? That removes the need to delete the load when no increment is found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D69740 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits