ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
The code LG, but my mac is at home, so I could not verify it.
@kbobyrev, would you mind running this on your machine?
================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:135
+ // On other platforms, just look for compilers on the PATH.
+ for (const char* Name : {"clang", "gcc", "ccc"})
+ if (auto PathCC = llvm::sys::findProgramByName(Name))
----------------
NIT: maybe add braces to the for statement?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70863/new/
https://reviews.llvm.org/D70863
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
