arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/CGCall.cpp:1775
- if (getLangOpts().OpenCL)
- FuncAttrs.addAttribute("denorms-are-zero",
- llvm::toStringRef(CodeGenOpts.FlushDenorm));
----------------
Anastasia wrote:
> arsenm wrote:
> > Anastasia wrote:
> > > so where would `denorms-are-zero` be emitted now (in case some out of
> > > tree implementations rely on this)?
> > Rely on in what sense? Do you have a concrete use of this?
> Since it has been emitted before in the module potentially some LLVM
> implementations could be using that attribute?
I'm disinclined to leave things around just in case some unknown user might
have been using them. We've dropped attributes like this before (I think the
less-precise-fp-mad one for disuse). This also isn't needed for correctness, so
it should be pretty safe to drop
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69878/new/
https://reviews.llvm.org/D69878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
