nridge abandoned this revision.
nridge marked an inline comment as done.
nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:153
+ // allowing go-to-definition to work at the end of an identifier.
+ if (Result.empty() && Offset > 0) {
+ Result = getDeclAtOffset(AST, Offset - 1, Relations);
----------------
hokein wrote:
> this looks a hacky workaround, I assume it may introduce other regression
> issues.
>
> I think https://reviews.llvm.org/D70773 and https://reviews.llvm.org/D70807
> should fix most annoying cases (function call).
Fair enough! Will abandon this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70727/new/
https://reviews.llvm.org/D70727
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
