aganea created this revision. aganea added reviewers: dblaikie, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea retitled this revision from "[Clang] Do not always assume others permissions are set" to "[Clang] In tests, do not always assume others permissions are set".
On my Linux Ubuntu box, permissions for "others" are always unset/empty, thus `clang/test/Misc/permissions.cpp` used to always fail. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70854 Files: clang/test/Misc/permissions.cpp Index: clang/test/Misc/permissions.cpp =================================================================== --- clang/test/Misc/permissions.cpp +++ clang/test/Misc/permissions.cpp @@ -3,9 +3,9 @@ // RUN: umask 000 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t // RUN: ls -l %t | FileCheck --check-prefix=CHECK000 %s -// CHECK000: rw-rw-rw- +// CHECK000: rw-rw-{{rw-|---}} // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t // RUN: ls -l %t | FileCheck --check-prefix=CHECK002 %s -// CHECK002: rw-rw-r-- +// CHECK002: rw-rw-{{r--|---}}
Index: clang/test/Misc/permissions.cpp =================================================================== --- clang/test/Misc/permissions.cpp +++ clang/test/Misc/permissions.cpp @@ -3,9 +3,9 @@ // RUN: umask 000 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t // RUN: ls -l %t | FileCheck --check-prefix=CHECK000 %s -// CHECK000: rw-rw-rw- +// CHECK000: rw-rw-{{rw-|---}} // RUN: umask 002 // RUN: %clang_cc1 -emit-llvm-bc %s -o %t // RUN: ls -l %t | FileCheck --check-prefix=CHECK002 %s -// CHECK002: rw-rw-r-- +// CHECK002: rw-rw-{{r--|---}}
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits