Hahnfeld added a comment. In D70804#1763443 <https://reviews.llvm.org/D70804#1763443>, @bryanpkc wrote:
> In D70804#1763289 <https://reviews.llvm.org/D70804#1763289>, @ABataev wrote: > > > Tests are required > > > The tests for this were added in D30644 <https://reviews.llvm.org/D30644>, > but they are currently failing on AArch64 due to D32035 > <https://reviews.llvm.org/D32035>. This patch allows those tests to pass > again. What further testing should I add? There should be tests in Clang that the target is indeed supported. Tests in libomptarget are fine, but apparently they are not tested on a regular basis when failing for more than two years. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
