lh123 marked an inline comment as done. lh123 added inline comments.
================ Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8"); ---------------- jhenderson wrote: > jhenderson wrote: > > `std::make_error_code(std::errc::illegal_byte_sequence)` -> > > `errc::illegal_byte_sequence` > LLVM has its own errc error_code set. Please use that, i.e. delete the > `std::` (note that I didn't add `std::` in my previous comment). I think we should use `std::errc::illegal_byte_sequence`, because it's sigature is: ``` template <typename... Ts> inline Error createStringError(std::errc EC, char const *Fmt, const Ts &... Vals) ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
