hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
The current error message doesn't fit well for cross-file rename.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70809
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
Index: clang-tools-extra/clangd/refactor/Rename.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/Rename.cpp
+++ clang-tools-extra/clangd/refactor/Rename.cpp
@@ -186,7 +186,7 @@
case ReasonToReject::NoSymbolFound:
return "there is no symbol at the given location";
case ReasonToReject::NoIndexProvided:
- return "symbol may be used in other files (no index available)";
+ return "no index provided";
case ReasonToReject::UsedOutsideFile:
return "the symbol is used outside main file";
case ReasonToReject::NonIndexable:
Index: clang-tools-extra/clangd/refactor/Rename.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/Rename.cpp
+++ clang-tools-extra/clangd/refactor/Rename.cpp
@@ -186,7 +186,7 @@
case ReasonToReject::NoSymbolFound:
return "there is no symbol at the given location";
case ReasonToReject::NoIndexProvided:
- return "symbol may be used in other files (no index available)";
+ return "no index provided";
case ReasonToReject::UsedOutsideFile:
return "the symbol is used outside main file";
case ReasonToReject::NonIndexable:
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
