thopre created this revision. thopre added a reviewer: thegameg. Herald added a project: clang. Herald added a subscriber: cfe-commits.
clang test Driver/darwin-opt-record.c assumes the default target is x86_64 by its uses of the -arch x86_64 and -arch x86_64h and thus fail on systems where it is not the case. Adding a target x86_64-apple-darwin10 reveals another problem: the driver refuses 2 -arch for an assembly output so this commit also changes the output to be an object file. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70748 Files: clang/test/Driver/darwin-opt-record.c Index: clang/test/Driver/darwin-opt-record.c =================================================================== --- clang/test/Driver/darwin-opt-record.c +++ clang/test/Driver/darwin-opt-record.c @@ -1,6 +1,6 @@ // REQUIRES: system-darwin -// RUN: %clang -### -S -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH +// RUN: %clang -target x86_64-apple-darwin10 -### -c -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH // // CHECK-MULTIPLE-ARCH: "-cc1" // CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64.opt.yaml"
Index: clang/test/Driver/darwin-opt-record.c =================================================================== --- clang/test/Driver/darwin-opt-record.c +++ clang/test/Driver/darwin-opt-record.c @@ -1,6 +1,6 @@ // REQUIRES: system-darwin -// RUN: %clang -### -S -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH +// RUN: %clang -target x86_64-apple-darwin10 -### -c -o FOO -fsave-optimization-record -arch x86_64 -arch x86_64h %s 2>&1 | FileCheck %s --check-prefix=CHECK-MULTIPLE-ARCH // // CHECK-MULTIPLE-ARCH: "-cc1" // CHECK-MULTIPLE-ARCH: "-opt-record-file" "FOO-x86_64.opt.yaml"
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
