lh123 marked an inline comment as done.
lh123 added inline comments.
================
Comment at: clang/lib/Tooling/CompilationDatabase.cpp:402
llvm::sys::path::append(DatabasePath, "compile_flags.txt");
- return FixedCompilationDatabase::loadFromFile(DatabasePath, ErrorMessage);
+ auto Base =
+ FixedCompilationDatabase::loadFromFile(DatabasePath, ErrorMessage);
----------------
kadircet wrote:
> is it really common for rsp files to show up in fixed compilation databases?
> since compile_flags.txt itself is also a file doesn't make much sense to
> refer to another one. as it can also contain text of arbitrary length.
Yes, rsp files usually only appear on the command line.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70222/new/
https://reviews.llvm.org/D70222
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
