alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
Looks good with one nit. Let me know if you need me to commit the patch for you. ================ Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:99 @@ +98,3 @@ + std::string Replacement = + (llvm::Twine("<") + llvm::Twine(CStyledHeaderToCxx[FileName]) + + llvm::Twine(">")) ---------------- No need to convert all of them to llvm::Twine. The first one is enough to make the compiler choose the right overloaded operators: (llvm::Twine("<") + CStyledHeaderToCxx[FileName] + ">").str(); http://reviews.llvm.org/D17484 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits