dblaikie added a comment. In D70111#1754702 <https://reviews.llvm.org/D70111#1754702>, @awpandey wrote:
> I am considering this > > - Will commit this without C bindings > - will give separate patch for C bindings and release notes (if necessary). > - will give another patch for Go bindings and release notes (if necessary). I'm not sure I follow - are you asking a question? Proposing a path forward you're planning to take (or this patch already represents)? I'd reiterate my previous request: Please update the go bindings and include a release note that this API is changing & why. (include that in this patch review & then it can be reviewed & all committed together to keep the whole source tree in a working state, because committing the change while either removing the C API or updating it without updating the Go bindings would break the Go bindings, which isn't good) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
