pi1024e created this revision.
pi1024e added a project: LLVM.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
pi1024e added a reviewer: llvm.org.
pi1024e edited reviewers, added: modocache, sammccall, Quuxplusone; removed:
llvm.org.
The assert statement says that the location must be a macroID, which is true.
However, the while statements checks for that again, which is unnecessary, and
gives warnings for returning a potentially non-initialized variable. For this
reason, I suggest changing the while to a do-while loop while keeping the
assert where it is.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D70603
Files:
clang/lib/Analysis/ReachableCode.cpp
Index: clang/lib/Analysis/ReachableCode.cpp
===================================================================
--- clang/lib/Analysis/ReachableCode.cpp
+++ clang/lib/Analysis/ReachableCode.cpp
@@ -138,10 +138,10 @@
static SourceLocation getTopMostMacro(SourceLocation Loc, SourceManager &SM) {
assert(Loc.isMacroID());
SourceLocation Last;
- while (Loc.isMacroID()) {
+ do {
Last = Loc;
Loc = SM.getImmediateMacroCallerLoc(Loc);
- }
+ } while (Loc.isMacroID());
return Last;
}
Index: clang/lib/Analysis/ReachableCode.cpp
===================================================================
--- clang/lib/Analysis/ReachableCode.cpp
+++ clang/lib/Analysis/ReachableCode.cpp
@@ -138,10 +138,10 @@
static SourceLocation getTopMostMacro(SourceLocation Loc, SourceManager &SM) {
assert(Loc.isMacroID());
SourceLocation Last;
- while (Loc.isMacroID()) {
+ do {
Last = Loc;
Loc = SM.getImmediateMacroCallerLoc(Loc);
- }
+ } while (Loc.isMacroID());
return Last;
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
