kousikk added inline comments.
================ Comment at: clang/include/clang-c/Dependencies.h:146 + */ +typedef struct CXOpaqueDependencyScannerWorker *CXDependencyScannerWorker; + ---------------- It would be simpler if the clients didn't have to worry about the worker? As far as a user of this lib is concerned, they need to create a shared cache, then call scanDeps() in some form with the shared cache and other inputs. Can we hide the worker inside the implementation? So essentially we create a new worker for every invocation (that's assuming worker setup is cheap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
