ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:200 + std::string Qualifier; + // FIXME: Also take using directives and namespace aliases inside function + // body into account. ---------------- kadircet wrote: > ilya-biryukov wrote: > > NIT: it looks like this FIXME belongs to the `getQualification` function > > itself. > I don't think so, as qualification function has no idea about the function > body, right? But it does handle using namespace directives and namespace aliases, so if we ever add this logic it better live in the same place, i.e. inside `getQualification` function or inside another overload handling that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69033/new/ https://reviews.llvm.org/D69033 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
