ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:659 + TYPE(TYPE([[Foo]])) foo3; + [[CAT]](Fo, o) foo4; + } ---------------- Previously we would not report any location at all in that case, right? Not sure how common this is, hope this won't blow up our index size too much. No need to change anything now, but we should be ready to revert if needed. Worth putting a comment here that AST-based XRefs behave in the same way. (And maybe adding a test there, if there isn't one already) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
