dschuff added a comment. LGTM on the approach, just one more question on the wasm-opt flags.
================ Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:105 + OOpt = "0"; + else if (A->getOption().matches(options::OPT_O)) + OOpt = A->getValue(); ---------------- This chain is slightly confusing. I assume this `getValue()` captures the number in `-O3`, `-O2`, etc? But why then do we need special-casing for 0 and 4 above? For that matter, we should probably not run wasm-opt at all if the opt-level is 0, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
