On Mon, Feb 22, 2016 at 4:44 PM, Aaron Ballman <aa...@aaronballman.com> wrote:
> On Mon, Feb 22, 2016 at 4:43 PM, Samuel Benzaquen <sbe...@google.com> > wrote: > > > > On Mon, Feb 22, 2016 at 4:19 PM, Aaron Ballman <aa...@aaronballman.com> > > wrote: > >> > >> On Mon, Feb 22, 2016 at 4:13 PM, Samuel Benzaquen via cfe-commits > >> <cfe-commits@lists.llvm.org> wrote: > >> > Author: sbenza > >> > Date: Mon Feb 22 15:13:02 2016 > >> > New Revision: 261574 > >> > > >> > URL: http://llvm.org/viewvc/llvm-project?rev=261574&view=rev > >> > Log: > >> > [ASTMatchers] Add matcher hasAnyName. > >> > > >> > Summary: Add matcher hasAnyName as an optimization over > >> > anyOf(hasName(),...) > >> > >> Does this mean we can get a clang-tidy check to convert > >> anyOf(hasName(), ...) into hasAnyName()? ;-) > >> > >> ~Aaron > > > > > > I would be simple, but I don't think it the cost/benefit is there. =) > > I changed all the checks manually in 5 minutes. > > I'll be sending that change soon. > > Haha, I was joking about the new check, but am really glad to hear > we'll be using the new AST matcher right away. Thank you for working > on this! > > ~Aaron > Matching the name of the nodes is a notable part of the CPU time of clang-tidy. This is why I spent time making it more efficient more than once already. _Sam
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits